[SSF-180] - Automated Emails 2 Implementation by swarkewalia · Pull Request #154 · Code-4-Community/ssf

swarkewalia · 2026-04-12T19:37:38Z

ℹ️ Issue

📝 Description

Implemented email templates for:

FM Recurring Donation Reminder
Tracking link becomes available
Pantry Confirms Order Delivery
All links use configurable domain variable

✔️ Verification

BEFORE TESTING: Add 2 new environment variables:

AWS_SES_SENDER_EMAIL (set this to one of your emails, this will be the address that sends the emails for you to verify)
SEND_AUTOMATED_EMAILS (switch this to true to turn on Cognito account creation and email sending permissions)
Add your email that you put in the AWS_SES_SENDER_EMAIL into the following AWS SES Identities: https://us-east-2.console.aws.amazon.com/ses/home?region=us-east-2#/identities

Tested each workflow to ensure the proper sender, subject, message, attachments were all there.

Same testing as #127

🏕️ (Optional) Future Work / Notes

emails go to spam :(

Juwang110

@sam-schu Should we be adding tests for the new email functionality like in #127

Juwang110 · 2026-04-18T02:37:38Z

+        expected donation.
+      </p>
+      <p>
+        Tracking Link: <a href="${params.trackingLink}">${params.trackingLink}</a>


Make "Tracking Link" bold

Juwang110 · 2026-04-18T02:40:08Z

+        recurring donations make a meaningful and consistent impact for the communities we serve.
+      </p>
+      <p>Best regards,<br />The Securing Safe Food Team</p>
+    `,


Can we add the additional link? The email template doc says:

"Additional Content (Links, Images, etc)
Link to make new donation (otherwise just the login link)"

For this, sorry the details weren't in the ticket, but we should use the resubmitDonationId query param in the link to navigate to the particular donation to resubmit - e.g., the end of the link might look like ?resubmitDonationId=5 if we're sending the reminder for donation 5 (the query param will not do anything yet but is being implemented this week in the frontend)

Juwang110 · 2026-04-18T02:41:25Z

+        Tracking Link: <a href="${params.trackingLink}">${params.trackingLink}</a>
+      </p>
+      <p>
+        You can use the tracking link above to monitor your shipment, or <a href="${EMAIL_REDIRECT_URL}/login">log into your portal</a> for full order details and updates.


I'm not sure if this should be a link for the "log into your portal", @sam-schu can you clarify?

it doesn't hurt!

Juwang110 · 2026-04-18T02:43:15Z

      .execute();
  }

+  // Updated confirmDelivery()


Don't think we need this

Juwang110 · 2026-04-18T02:45:41Z


    await this.requestsService.updateRequestStatus(order.requestId);

+    const { subject, bodyHTML } = emailTemplates.pantryConfirmsOrderDelivery({


In Dalton's PR, he wrapped this logic in a try catch with an InternalServerErrorException, can we mimic that pattern here for consistency

Juwang110 · 2026-04-18T02:48:17Z

+              if (fmEmails.length > 0) {
+                await this.emailsService.sendEmails(fmEmails, cs, cb);
+              }
+            } catch (e) {


Same as above

Juwang110 · 2026-04-18T02:48:59Z

+              ].filter((e): e is string => e !== null);
+
+              if (fmEmails.length > 0) {
+                await this.emailsService.sendEmails(fmEmails, cs, cb);


Can we rename cs and cb to subject and bodyHTML for consistency

Juwang110 · 2026-04-18T03:11:27Z

+          });
+
+        try {
+          const fmEmails = [


I think we should be sending the email to the FMRep's contact email as well as maybe this secondary one? @sam-schu could you confirm?

Yes, it should only be the representative's email!

Juwang110 · 2026-04-18T03:11:41Z

+
+            try {
+              const fmEmails = [
+                donation.foodManufacturer.secondaryContactEmail,


Same comment about email

Juwang110 · 2026-04-18T03:13:59Z

+        volunteerEmail: order.assignee.email,
+      });
+
+      const pantryEmails = [order.request.pantry.secondaryContactEmail].filter(


Same comment here about email, I could be wrong though

yes should be pantry representative email again!

sam-schu

+1 on Justin's comment for adding tests!

sam-schu · 2026-04-20T01:59:54Z

+          });
+
+        try {
+          const fmEmails = [


Yes, it should only be the representative's email!

sam-schu · 2026-04-20T02:37:12Z

+        recurring donations make a meaningful and consistent impact for the communities we serve.
+      </p>
+      <p>Best regards,<br />The Securing Safe Food Team</p>
+    `,


For this, sorry the details weren't in the ticket, but we should use the resubmitDonationId query param in the link to navigate to the particular donation to resubmit - e.g., the end of the link might look like ?resubmitDonationId=5 if we're sending the reminder for donation 5 (the query param will not do anything yet but is being implemented this week in the frontend)

sam-schu · 2026-04-20T03:54:51Z

+          if (fmEmails.length > 0) {
+            await this.emailsService.sendEmails(fmEmails, subject, bodyHTML);
+          }
+        } catch (e) {


I don't think we should throw an exception for email failures in this method, continue/break as the existing placeholder code had is the right thing to do for control flow. The service functions Dalton updated were called by controller methods and the email sending was the last thing done in the function, so the exception would serve to let the caller know that the email failed but wouldn't affect the functionality otherwise because the function was going to return anyway. This function is called by a cron job to send all the reminders for a day, and we want to continue trying to send emails for other donations even if one of them fails. It would be good to log a warning in this case though

sam-schu · 2026-04-20T04:02:05Z

+        volunteerEmail: order.assignee.email,
+      });
+
+      const pantryEmails = [order.request.pantry.secondaryContactEmail].filter(


yes should be pantry representative email again!

sam-schu · 2026-04-20T04:05:45Z

      order.status = OrderStatus.SHIPPED;
      order.shippedAt = new Date();
+
+      const { subject, bodyHTML } = emailTemplates.trackingLinkAvailable({


Given we will be throwing an exception if the email fails, we should make sure to send the email after saving the order to the database so we still update the order even if the email fails

sam-schu · 2026-04-20T04:14:24Z

+        Tracking Link: <a href="${params.trackingLink}">${params.trackingLink}</a>
+      </p>
+      <p>
+        You can use the tracking link above to monitor your shipment, or <a href="${EMAIL_REDIRECT_URL}/login">log into your portal</a> for full order details and updates.


it doesn't hurt!

swarkewalia added 2 commits April 12, 2026 15:08

automated email updates

e1fd3af

fix donation tests

de35710

swarkewalia requested review from Juwang110 and sam-schu April 17, 2026 01:38

Juwang110 reviewed Apr 18, 2026

View reviewed changes

sam-schu requested changes Apr 20, 2026

View reviewed changes


		await this.requestsService.updateRequestStatus(order.requestId);

		const { subject, bodyHTML } = emailTemplates.pantryConfirmsOrderDelivery({

Conversation

swarkewalia commented Apr 12, 2026

ℹ️ Issue

📝 Description

✔️ Verification

🏕️ (Optional) Future Work / Notes

Uh oh!

Juwang110 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sam-schu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sam-schu left a comment •

edited

Loading